Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table with controlled filteredValue empty array should not highlight the filtered icon #24263

merged 2 commits into from May 18, 2020


Copy link

@zombieJ zombieJ commented May 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table with empty array filteredValue still highlight the filtered icon.
🇨🇳 Chinese 修复 Table 在 filteredValue 使用空数组时仍然会高亮过滤图标的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

Copy link

@ant-design-bot ant-design-bot commented May 18, 2020

Copy link

@codecov codecov bot commented May 18, 2020

Codecov Report

Merging #24263 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24263   +/-   ##
  Coverage   98.81%   98.81%           
  Files         363      363           
  Lines        7281     7281           
  Branches     2016     2015    -1     
  Hits         7195     7195           
  Misses         86       86           
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64558d...6d3fa17. Read the comment docs.

@zombieJ zombieJ merged commit 44cfc35 into master May 18, 2020
33 of 34 checks passed
@zombieJ zombieJ deleted the fix-table-filter branch May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants