Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty in cascader/select/table/treeSelect #24279

Merged
merged 2 commits into from May 19, 2020
Merged

fix: empty in cascader/select/table/treeSelect #24279

merged 2 commits into from May 19, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 19, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24276

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Cascader/Select/Table/TresSelect text color when data empty
🇨🇳 Chinese 修复 Cascader/Select/Table/TreeSelect 空数据时字体的颜色

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg changed the title fix: empty in cascader\select\table\treeSelect fix: empty in cascader/select/table/treeSelect May 19, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 19, 2020

@codecov
Copy link

@codecov codecov bot commented May 19, 2020

Codecov Report

Merging #24279 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24279   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         363      363           
  Lines        7281     7282    +1     
  Branches     2006     2017   +11     
=======================================
+ Hits         7195     7196    +1     
  Misses         86       86           
Impacted Files Coverage Δ
components/table/Table.tsx 99.23% <ø> (ø)
components/cascader/index.tsx 97.22% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd1088...268d752. Read the comment docs.

@xrkffgg xrkffgg requested review from zombieJ and afc163 May 19, 2020
@afc163 afc163 merged commit ce78029 into master May 19, 2020
35 checks passed
@afc163 afc163 deleted the fix-empty branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants