Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: optimize cascader rtl style #24520

Merged
merged 1 commit into from May 28, 2020
Merged

style: optimize cascader rtl style #24520

merged 1 commit into from May 28, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before

image

After

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Cascader dropdown style in RTL.
🇨🇳 Chinese 优化 Cascader RTL 模式下拉框的样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented May 28, 2020

横线 可以直接看出来,border-radius 太小,看不太出来。

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented May 28, 2020

话说 GitHub 换 UI 了啊

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 28, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 28, 2020

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 28, 2020

我一直想研究下他们的缓存处理机制

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 28, 2020

好像是多页的,fetch加载非首页。

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented May 28, 2020

评论的时间,Edit 的历史

好多地方 都值得研究啊 😂😂

@codecov
Copy link

@codecov codecov bot commented May 28, 2020

Codecov Report

Merging #24520 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24520   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         363      363           
  Lines        7235     7235           
  Branches     2018     1970   -48     
=======================================
  Hits         7172     7172           
  Misses         63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b54bd7...82dc4d3. Read the comment docs.

@afc163 afc163 merged commit 3712832 into master May 28, 2020
37 checks passed
@afc163 afc163 deleted the opt-cascader-rtl branch May 28, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants