Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]chore: remove raf #24581

Closed
wants to merge 3 commits into from
Closed

[WIP]chore: remove raf #24581

wants to merge 3 commits into from

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 29, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref: #22698

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Remove raf in dependencies
🇨🇳 Chinese 移除raf依赖

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 29, 2020

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #24581 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #24581   +/-   ##
========================================
  Coverage    98.96%   98.96%           
========================================
  Files          364      364           
  Lines         7408     7408           
  Branches      2050     2059    +9     
========================================
  Hits          7331     7331           
  Misses          77       77           
Impacted Files Coverage Δ
components/_util/openAnimation.tsx 96.42% <ø> (ø)
components/_util/raf.ts 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/form/util.ts 100.00% <ø> (ø)
components/_util/throttleByAnimationFrame.tsx 95.45% <100.00%> (ø)
components/slider/SliderTooltip.tsx 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d7038...fd84335. Read the comment docs.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fd84335:

Sandbox Source
antd reproduction template Configuration

@yoyo837 yoyo837 closed this Nov 18, 2020
@yoyo837 yoyo837 deleted the remove-raf branch November 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants