Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submenu scroll issue #24800

Closed
wants to merge 1 commit into from
Closed

Conversation

sbardian
Copy link

@sbardian sbardian commented Jun 7, 2020

πŸ€” This is a ...

  • Bug fix

πŸ”— Related issue link

Fixes #24064

Broken scroll on submenus

πŸ’‘ Background and solution

Seems the position: absolute; was breaking the scroll. I don't see it break any of the other examples, but I'm new here so Β―\(ツ)/Β― could be wrong. . . Also removed top, left, right, and bottom properties as they will no longer do any good.

πŸ“ Changelog

Fix: broken scroll on SubMenu component

Language Changelog
πŸ‡ΊπŸ‡Έ English X
πŸ‡¨πŸ‡³ Chinese

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 7, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 7, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd91a41:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #24800 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24800   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7295     7295           
  Branches     1990     2042   +52     
=======================================
  Hits         7238     7238           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6129d3a...bd91a41. Read the comment docs.

afc163 added a commit that referenced this pull request Jun 7, 2020
@afc163 afc163 mentioned this pull request Jun 7, 2020
17 tasks
@afc163 afc163 closed this in #24806 Jun 7, 2020
afc163 added a commit that referenced this pull request Jun 7, 2020
@sbardian sbardian deleted the submenu-scroll branch June 7, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll in popup container
2 participants