Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drawer cannot open #24802

Merged
merged 2 commits into from Jun 7, 2020
Merged

fix: Drawer cannot open #24802

merged 2 commits into from Jun 7, 2020

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Jun 7, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #24797

📝 Changelog

Language Changelog
🇺🇸 English Fix Drawer cannot open.
🇨🇳 Chinese 修复 Drawer 无法显示的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

@afc163 afc163 commented Jun 7, 2020

要补一个有用的用例,不改会挂的那种。。

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 7, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 7, 2020

@chenshuai2144
Copy link
Contributor Author

@chenshuai2144 chenshuai2144 commented Jun 7, 2020

正在,好久没看这个都忘记为啥都要默认设置 getContainer=false 了

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3208d33:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 7, 2020

Codecov Report

Merging #24802 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24802   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7295     7295           
  Branches     1990     2042   +52     
=======================================
  Hits         7238     7238           
  Misses         57       57           
Impacted Files Coverage Δ
components/drawer/index.tsx 98.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6129d3a...3208d33. Read the comment docs.

@afc163 afc163 changed the title fix: fix the bug that drawer cannot render by default fix: Drawer cannot open Jun 7, 2020
@afc163 afc163 merged commit 30217ad into master Jun 7, 2020
37 checks passed
@afc163 afc163 deleted the drawer_bugifx branch Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants