Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Tree Icon prop #25080

Merged
merged 5 commits into from
Jun 18, 2020
Merged

docs: add Tree Icon prop #25080

merged 5 commits into from
Jun 18, 2020

Conversation

fireairforce
Copy link
Member

@fireairforce fireairforce commented Jun 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

closes #25070

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English None.
🇨🇳 Chinese 无。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/tree/index.en-US.md
View rendered components/tree/index.zh-CN.md

Copy link
Contributor

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Thanks!

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 18, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 18, 2020

@xrkffgg
Copy link
Member

xrkffgg commented Jun 18, 2020

新增的,发 feature 吧

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9288cdb971ac7da5adf5e7c1d0042d9c50b8124c:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0326f86:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #25080 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25080   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files         365      365           
  Lines        7296     7296           
  Branches     2041     1990   -51     
=======================================
  Hits         7251     7251           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e8579...0326f86. Read the comment docs.

@fireairforce
Copy link
Member Author

新增的,发 feature 吧

不是新增的,本来就有这个api,加个文档说明

@@ -52,6 +52,7 @@ Almost anything can be represented in a tree structure. Examples include directo
| onLoad | Callback function for when a treeNode is loaded | function(loadedKeys, {event, node}) | - | |
| onRightClick | Callback function for when the user right clicks a treeNode | function({event, node}) | - | |
| onSelect | Callback function for when the user clicks a treeNode | function(selectedKeys, e:{selected: bool, selectedNodes, node, event}) | - | |
| icon | customize treeNode icon. | ReactNode/Function(props):ReactNode | - | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| icon | customize treeNode icon. | ReactNode/Function(props):ReactNode | - | |
| icon | customize treeNode icon. | ReactNode \| (props) => ReactNode | - | |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok了

@xrkffgg
Copy link
Member

xrkffgg commented Jun 18, 2020

https://ant.design/components/tree-cn/#TreeNode-props 这个中 不是有 icon 嘛?

@afc163
Copy link
Member

afc163 commented Jun 18, 2020

image

不是 feature changelog 不能这么写。

@hi-rustin
Copy link
Contributor

https://ant.design/components/tree-cn/#TreeNode-props 这个中 不是有 icon 嘛?

这是节点的,不是tree的。

@fireairforce
Copy link
Member Author

image

不是 feature changelog 不能这么写。

好的,已修改

@fireairforce
Copy link
Member Author

https://ant.design/components/tree-cn/#TreeNode-props 这个中 不是有 icon 嘛?

顺手把这个里面的文档也调整了一下

@@ -60,7 +61,7 @@ Almost anything can be represented in a tree structure. Examples include directo
| checkable | When Tree is checkable, set TreeNode display Checkbox or not | boolean | - |
| disableCheckbox | Disables the checkbox of the treeNode | boolean | false | |
| disabled | Disables the treeNode | boolean | false | |
| icon | customize icon. When you pass component, whose render will receive full TreeNode props as component props | ReactNode/Function(props):ReactNode | - | |
| icon | customize icon. When you pass component, whose render will receive full TreeNode props as component props | ReactNode\| (props) => ReactNode | - | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| icon | customize icon. When you pass component, whose render will receive full TreeNode props as component props | ReactNode\| (props) => ReactNode | - | |
| icon | customize icon. When you pass component, whose render will receive full TreeNode props as component props | ReactNode \| (props) => ReactNode | - | |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xrkffgg
Copy link
Member

xrkffgg commented Jun 18, 2020

😅 我指出哪个,你就只改哪个啊,你好歹看看其他的呢、、、、

@fireairforce
Copy link
Member Author

😅 我指出哪个,你就只改哪个啊,你好歹看看其他的呢、、、、

我错了😭 QuQ

@afc163 afc163 merged commit e22cb6a into ant-design:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'icon' prop to Tree API
5 participants