Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload don't support Popover #25090

Merged
merged 1 commit into from Jun 19, 2020
Merged

fix: Upload don't support Popover #25090

merged 1 commit into from Jun 19, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25077

💡 Background and solution

fixed in react-component/upload@472a3d6

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload don't support Popover.
🇨🇳 Chinese 修复 Upload 不支持包裹 Popover 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 18, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 18, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f6b86d:

Sandbox Source
antd reproduction template Configuration
great-poincare-snmrr Issue #25077

@codecov
Copy link

@codecov codecov bot commented Jun 18, 2020

Codecov Report

Merging #25090 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25090   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files         365      365           
  Lines        7296     7296           
  Branches     1990     2040   +50     
=======================================
  Hits         7251     7251           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1f590...3f6b86d. Read the comment docs.

@afc163 afc163 merged commit 2b4d049 into master Jun 19, 2020
38 checks passed
@afc163 afc163 deleted the fix-upload-events branch Jun 19, 2020
@afc163 afc163 mentioned this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants