Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IE11 can not close Tabs #25200

Merged
merged 4 commits into from
Jun 24, 2020
Merged

fix: IE11 can not close Tabs #25200

merged 4 commits into from
Jun 24, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #25153

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs can not close in IE 11.
🇨🇳 Chinese 修复 Tabs 在 IE 11 下无法关闭的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 24, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 24, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 24, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a42fe9:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc33a8f:

Sandbox Source
antd reproduction template Configuration

afc163
afc163 reviewed Jun 24, 2020
View reviewed changes
components/tabs/style/index.less
@@ -175,6 +171,10 @@
cursor: not-allowed;
}

& &-remove .@{iconfont-css-prefix} {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
& &-remove .@{iconfont-css-prefix} {
&-remove .@{iconfont-css-prefix} {

Copy link
Member Author

@zombieJ zombieJ Jun 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不能删。会被 .tabs .@{iconfont-css-prefix} 冲掉。

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd16e4e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #25200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25200   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         365      365           
  Lines        7302     7302           
  Branches     1993     2043   +50     
=======================================
  Hits         7261     7261           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb586d...5a42fe9. Read the comment docs.

@zombieJ zombieJ merged commit 7ef283a into master Jun 24, 2020
@zombieJ zombieJ deleted the fix-tabs-ie11 branch June 24, 2020 09:55
@yoyo837
Copy link
Contributor

yoyo837 commented Jun 24, 2020

节前打版本不？

@zombieJ
Copy link
Member Author

zombieJ commented Jun 24, 2020

还是周末发版本~

@chenshuai2144 chenshuai2144 mentioned this pull request Jun 28, 2020
Merged
13 tasks
xrkffgg pushed a commit that referenced this pull request Jun 28, 2020
@zombieJ @xrkffgg
fix: IE11 can not close Tabs (#25200)
fbf2407 
* fix: IE11 can not close Tabs

* update snapshot

* fix style lint

* move -remove icon clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs 在ie11下无法关闭
4 participants
@zombieJ @ant-design-bot @yoyo837 @afc163