Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select icon interactive #25212

Merged
merged 2 commits into from Jun 24, 2020
Merged

fix: Select icon interactive #25212

merged 2 commits into from Jun 24, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #25179

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select suffix icon can not focus input.
🇨🇳 Chinese 修复 Select 点击下拉箭头时输入框不能获得焦点的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 24, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 24, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 648b05b:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25179

@afc163
Copy link
Member

@afc163 afc163 commented Jun 24, 2020

snapshot

@codecov
Copy link

@codecov codecov bot commented Jun 24, 2020

Codecov Report

Merging #25212 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25212   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         365      365           
  Lines        7302     7303    +1     
  Branches     2044     2043    -1     
=======================================
+ Hits         7261     7262    +1     
  Misses         41       41           
Impacted Files Coverage Δ
components/select/index.tsx 100.00% <ø> (ø)
components/tree-select/index.tsx 97.77% <ø> (ø)
components/select/utils/iconUtil.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d32a7...648b05b. Read the comment docs.

@zombieJ zombieJ merged commit 67513cc into master Jun 24, 2020
37 checks passed
@zombieJ zombieJ deleted the fix-select branch Jun 24, 2020
@chenshuai2144 chenshuai2144 mentioned this pull request Jun 28, 2020
13 tasks
xrkffgg pushed a commit that referenced this issue Jun 28, 2020
* fix: Select icon interactive

* updat snasphot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants