-
-
Notifications
You must be signed in to change notification settings - Fork 50.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: form item dep #25408
feat: form item dep #25408
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e73f01:
|
30184ff
to
457a8b5
Compare
Codecov Report
@@ Coverage Diff @@
## feature #25408 +/- ##
========================================
Coverage 99.50% 99.50%
========================================
Files 368 368
Lines 7300 7303 +3
Branches 2048 2001 -47
========================================
+ Hits 7264 7267 +3
Misses 36 36
Continue to review full report at Codecov.
|
components/form/FormItem.tsx
Outdated
@@ -299,14 +299,21 @@ function FormItem(props: FormItemProps): React.ReactElement { | |||
}; | |||
|
|||
let childNode: React.ReactNode = null; | |||
if (shouldUpdate && dependencies) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
放到 devWarning
的条件里去。
文档还要补一下什么时候支持的 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #21645
💡 Background and solution
📝 Changelog
dependencies
to control updating logic with render props children.dependencies
控制更新逻辑。☑️ Self Check before Merge
View rendered components/form/demo/dep-debug.md