Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Popover wrong position when using Radio.Button #25449

Merged
merged 4 commits into from Jul 7, 2020

Conversation

zgoby
Copy link
Contributor

@zgoby zgoby commented Jul 6, 2020

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

close #25222

💡 需求背景和解决方案

  1. Popover定位问题
  2. 我仔细看了Align是使用rc-trigger里的getRootDomNode函数返回作为定位元素的,这个函数获得值是span.ant-radio-button
  3. 根据这个类名来说应该是侵入最小的与改js相比
  4. 我在本地查看了对应组件显示正常

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文 Fix Popover wrong positioning on Radio.Button.
🇨🇳 中文 修复 Radio.Button 上使用 Popover 时的位置异常问题。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 6, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 6, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 720baab:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #25449 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25449      +/-   ##
==========================================
+ Coverage   99.47%   99.51%   +0.04%     
==========================================
  Files         368      368              
  Lines        7204     7204              
  Branches     2002     2009       +7     
==========================================
+ Hits         7166     7169       +3     
+ Misses         38       35       -3     
Impacted Files Coverage Δ
components/carousel/index.tsx 100.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a32e8a...720baab. Read the comment docs.

@afc163 afc163 changed the title fix Popover wrong position when using Radio.Button fix: Popover wrong position when using Radio.Button Jul 6, 2020
@afc163
Copy link
Member

afc163 commented Jul 6, 2020

请按 PR 的模板填写。

@@ -34,6 +34,7 @@ timeline: true
- Radio
- 🐞 Fix Radio.Group throw `Function components cannot be given refs` warning message. [#25328](https://github.com/ant-design/ant-design/pull/25328)
- 🐞 Fix Radio.Group style with extra spaces in `children`. [#25304](https://github.com/ant-design/ant-design/pull/25304) [@ElderJames](https://github.com/ElderJames)
- 🐞 Fix Radio.Button style `Popover wrong positioning when using Radio.Button`. [#25449](https://github.com/ant-design/ant-design/pull/25449)
Copy link
Member

@afc163 afc163 Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请补充到

image

这里不要动。

@afc163
Copy link
Member

afc163 commented Jul 7, 2020

关于 changelog

  1. 中英文之间加空格。
  2. 只有代码和 API 要包裹 `。
  3. 出现了两次 Radio.Button,文法不够简洁。

@afc163 afc163 merged commit 75645c4 into ant-design:master Jul 7, 2020
20 of 25 checks passed
@zombieJ zombieJ mentioned this pull request Jul 11, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants