Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add size props for Badge #25851

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Conversation

moonrailgun
Copy link
Contributor

@moonrailgun moonrailgun commented Jul 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25371

💡 Background and solution

Add a size props for component Badge

In some case, default size is too large

📝 Changelog

Language Changelog
🇺🇸 English Add new props size for Badge
🇨🇳 Chinese Badge 新增 size 属性用于设置大小。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/badge/demo/size.md
View rendered components/badge/index.en-US.md
View rendered components/badge/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 28, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 28, 2020

@afc163
Copy link
Member

afc163 commented Jul 28, 2020

feature branch please~

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 59e8980:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25371

@moonrailgun moonrailgun changed the base branch from master to feature July 28, 2020 05:16
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #25851 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25851   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files          374      374           
  Lines         7309     7310    +1     
  Branches      1991     2040   +49     
========================================
+ Hits          7274     7275    +1     
  Misses          35       35           
Impacted Files Coverage Δ
components/badge/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f208e...59e8980. Read the comment docs.

components/badge/index.en-US.md Outdated Show resolved Hide resolved
components/badge/style/index.less Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Jul 28, 2020

image

补充一下

@moonrailgun
Copy link
Contributor Author

@afc163 已更新

@afc163 afc163 merged commit 74d13f4 into ant-design:feature Jul 28, 2020
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants