Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor carousel style #25906

Merged
merged 2 commits into from Jul 30, 2020
Merged

Refactor carousel style #25906

merged 2 commits into from Jul 30, 2020

Conversation

07akioni
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #25878

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Carousel children height smaller then parent node issue. Remove Carousel slide transparent border.
🇨🇳 Chinese 修复 Carousel 内子节点高度和容器相差几个像素的问题。移除 Carousel 内部节点的透明边框。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 30, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 30, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e649951:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #25906 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25906   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7307     7307           
  Branches     2039     2032    -7     
=======================================
  Hits         7276     7276           
  Misses         31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8800b56...e649951. Read the comment docs.

@afc163 afc163 merged commit 0dff111 into master Jul 30, 2020
@afc163 afc163 deleted the refactor-carousel-style branch July 30, 2020 06:06
@afc163 afc163 mentioned this pull request Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel走马灯样式问题-轮播项比内容区高度多出两个像素
3 participants