Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: DatePicker demo refactor #25913

Merged
merged 5 commits into from
Jul 30, 2020
Merged

docs: DatePicker demo refactor #25913

merged 5 commits into from
Jul 30, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 30, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Add a demo in which DatePicker type can be changed.
更新一个可修改类型的 Demo
image

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/date-picker/demo/change-type.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 30, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 30, 2020

console.log(value);
};
return (
<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 Space 吧,TypeSelect 用 marginRight ,在 RTL 下样式又不太好了。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9162d6f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #25913 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25913   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7307     7307           
  Branches     2032     1991   -41     
=======================================
  Hits         7276     7276           
  Misses         31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dff111...9162d6f. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Jul 30, 2020

可以合并到 basic demo 中

@07akioni 07akioni changed the title docs: DatePicker change type demo docs: DatePicker demo refactor Jul 30, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2020

Size Change: +127 B (0%)

Total Size: 1.83 MB

Filename Size Change
dist/antd-with-locales.js 637 kB +34 B (0%)
dist/antd-with-locales.min.js 311 kB +28 B (0%)
dist/antd.js 595 kB +41 B (0%)
dist/antd.min.js 279 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/compact-theme.js 120 B 0 B
dist/dark-theme.js 118 B 0 B
dist/default-theme.js 7.21 kB 0 B
dist/theme.js 4.14 kB 0 B

compressed-size-action

@07akioni 07akioni merged commit 5a08aab into master Jul 30, 2020
@07akioni 07akioni deleted the docs-date-picker branch July 30, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants