Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add @text-color in dark #25923

Merged
merged 1 commit into from Jul 31, 2020
Merged

style: add @text-color in dark #25923

merged 1 commit into from Jul 31, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jul 31, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

补充 #25630

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 31, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 31, 2020

Copy link
Contributor

@07akioni 07akioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

why not 65%?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e3b7c70:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #25923 into feature will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #25923      +/-   ##
===========================================
+ Coverage    98.81%   99.57%   +0.75%     
===========================================
  Files          363      373      +10     
  Lines         7280     7309      +29     
  Branches      1967     2042      +75     
===========================================
+ Hits          7194     7278      +84     
+ Misses          86       31      -55     
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/usePatchElement.tsx 100.00% <ø> (ø)
components/affix/index.tsx 99.13% <ø> (ø)
components/checkbox/Checkbox.tsx 100.00% <ø> (ø)
components/config-provider/context.tsx 100.00% <ø> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <ø> (ø)
components/date-picker/locale/nb_NO.tsx 100.00% <ø> (ø)
components/date-picker/locale/tr_TR.tsx 100.00% <ø> (ø)
components/descriptions/Cell.tsx 100.00% <ø> (ø)
components/_util/motion.tsx 100.00% <100.00%> (ø)
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d7231...e3b7c70. Read the comment docs.

@xrkffgg
Copy link
Member Author

xrkffgg commented Jul 31, 2020

feature 的 default 已经改成 85 % 啦 https://github.com/ant-design/ant-design/pull/25630/files

@07akioni
Copy link
Contributor

feature 的 default 已经改成 85 % 啦 https://github.com/ant-design/ant-design/pull/25630/files

那看来是缺乏同步,没问题了hhh

@xrkffgg
Copy link
Member Author

xrkffgg commented Jul 31, 2020

来个 approve

@xrkffgg xrkffgg merged commit 35c44d0 into feature Jul 31, 2020
@xrkffgg xrkffgg deleted the add-dark branch July 31, 2020 07:00
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
1 task
@zkwolf zkwolf mentioned this pull request Feb 6, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants