Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show line in Tree first level #25991

Merged
merged 4 commits into from
Aug 10, 2020
Merged

Conversation

zhangchen915
Copy link
Contributor

@zhangchen915 zhangchen915 commented Aug 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25950

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tree lost line between top level nodes when enable showLine.
🇨🇳 Chinese 修复 Tree 开启 showLine 时顶级节点间缺少连接线的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 3, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 3, 2020

@zhangchen915 zhangchen915 changed the title feat: tree line in first level feat: show line in Tree first level Aug 3, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bed7a78:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented Aug 4, 2020

image

最后一个节点不应该有,只有节点间有连接线。

@zhangchen915
Copy link
Contributor Author

最后一个节点没有的话,现在的Demo会看不出效果,是否需要更新一下?

@afc163
Copy link
Member

afc163 commented Aug 5, 2020

是的,你可以改改 demo。

@zhangchen915
Copy link
Contributor Author

这个还需要 rc-tree 先发个版本 react-component/tree#360

@afc163 afc163 merged commit 4da2260 into ant-design:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree组件,第一层子节点之间缺少连接线
3 participants