Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: New Form.Item validate design #26824

Closed
wants to merge 11 commits into from
Closed

[WIP] feat: New Form.Item validate design #26824

wants to merge 11 commits into from

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 19, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Group 24

📝 Changelog

Language Changelog
🇺🇸 English New Form.Item validation style design. Provides feedback & feedbackIcon for customize validation. Deprecated help & hasFeedback.
🇨🇳 Chinese 全新的 Form.Item 校验样式设计。新增 feedback & feedbackIcon属性用于自定义校验。 原 help & hasFeedback 属性废弃。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/disabled-input-debug.md
View rendered components/form/demo/register.md
View rendered components/form/demo/validate-other.md
View rendered components/form/demo/validate-static-legacy.md
View rendered components/form/demo/validate-static.md
View rendered components/form/demo/without-form-create.md
View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 19, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 19, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 204a526:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #26824 (204a526) into feature (659a2d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #26824   +/-   ##
========================================
  Coverage    99.83%   99.83%           
========================================
  Files          385      386    +1     
  Lines         7408     7418   +10     
  Branches      2072     2033   -39     
========================================
+ Hits          7396     7406   +10     
  Misses          12       12           
Impacted Files Coverage Δ
components/form/FormList.tsx 100.00% <ø> (ø)
components/form/context.tsx 100.00% <ø> (ø)
components/_util/hooks/useIsomorphicEffect.ts 100.00% <100.00%> (ø)
components/form/ErrorList.tsx 96.55% <100.00%> (+0.55%) ⬆️
components/form/FormItem.tsx 100.00% <100.00%> (ø)
components/form/FormItemInput.tsx 100.00% <100.00%> (ø)
components/form/hooks/useStatusFeedback.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659a2d7...204a526. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +284 B (0%)

Total Size: 801 kB

Filename Size Change
./dist/antd-with-locales.min.js 317 kB +126 B (0%)
./dist/antd.compact.min.css 66.4 kB +17 B (0%)
./dist/antd.dark.min.css 67.7 kB +11 B (0%)
./dist/antd.min.css 66.4 kB +12 B (0%)
./dist/antd.min.js 283 kB +118 B (0%)

compressed-size-action

@afc163
Copy link
Member

afc163 commented Sep 22, 2020

image

  1. 没对齐。
  2. 感觉图标比设计稿上的略大。

@afc163
Copy link
Member

afc163 commented Sep 22, 2020

image

说实话,这个默认效果有点太重了,尤其是实心的红色错误 icon。

@afc163
Copy link
Member

afc163 commented Sep 22, 2020

对设计来说算是 break changing。

Form 上的 feedbackIcon 也要提供,让用户可以统一关掉,包括 ConfigProvider。

@zombieJ zombieJ changed the title feat: New Form.Item validate design [WIP] feat: New Form.Item validate design Sep 22, 2020
@zombieJ
Copy link
Member Author

zombieJ commented Sep 22, 2020

先改成 WIP,和设计师再同步一下

@yuxuan
Copy link
Contributor

yuxuan commented Dec 15, 2020

当有extra的时候,这个会怎么展示呢? 当有多个validate message展示的时候,每个都会有icon么?

@xrkffgg xrkffgg removed the Inactive label Dec 26, 2020
@zombieJ zombieJ closed this Feb 16, 2021
@zombieJ zombieJ deleted the form-status branch February 16, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants