Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve useCombinedRefs #27352

Merged
merged 1 commit into from
Oct 24, 2020
Merged

chore: improve useCombinedRefs #27352

merged 1 commit into from
Oct 24, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Oct 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 24, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91e2636:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #27352 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7384      7384           
  Branches      2026      2026           
=========================================
  Hits          7384      7384           
Impacted Files Coverage Δ
components/_util/hooks/useCombinedRefs.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0245e7...91e2636. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 791 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 314 kB 0 B
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.7 kB 0 B
./dist/antd.min.css 66.4 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@hengkx hengkx merged commit 5e85ce4 into master Oct 24, 2020
@hengkx hengkx deleted the improve branch October 24, 2020 15:53
zombieJ added a commit that referenced this pull request Oct 26, 2020
* fix: border style of Input.Search when allowClear (#27325)

* fix: border style of Input.Search when allowClear

* fix css

* update

* change name

* docs: 4.7.3 changelog (#27350)

* docs: 4.7.3 changelog

* docs: Patch 27325

* chore: improve useCombinedRefs (#27352)

* docs: 📝 update introduce

* chore: fix API table border

* chore: Adjust collapse arrow position align with first line

Co-authored-by: xrk <xrkffgg@gmail.com>
Co-authored-by: Tom Xu <ycxzhkx@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
07akioni pushed a commit that referenced this pull request Nov 7, 2020
* fix: border style of Input.Search when allowClear (#27325)

* fix: border style of Input.Search when allowClear

* fix css

* update

* change name

* docs: 4.7.3 changelog (#27350)

* docs: 4.7.3 changelog

* docs: Patch 27325

* chore: improve useCombinedRefs (#27352)

* docs: 📝 update introduce

* chore: fix API table border

* chore: Adjust collapse arrow position align with first line

Co-authored-by: xrk <xrkffgg@gmail.com>
Co-authored-by: Tom Xu <ycxzhkx@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants