Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trans-button): rewrite with hook #27743

Merged
merged 7 commits into from
Nov 18, 2020
Merged

refactor(trans-button): rewrite with hook #27743

merged 7 commits into from
Nov 18, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Nov 13, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hengkx
Copy link
Member Author

hengkx commented Nov 13, 2020

change log 无能为力了🤣

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 13, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2020

Size Change: -199 B (0%)

Total Size: 789 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB -98 B (0%)
./dist/antd.min.js 276 kB -101 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1590860:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #27743 (7ba1c96) into master (696396a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          390       390           
  Lines         7382      7381    -1     
  Branches      2044      2093   +49     
=========================================
- Hits          7382      7381    -1     
Impacted Files Coverage Δ
components/_util/transButton.tsx 100.00% <100.00%> (ø)
components/typography/Base.tsx 100.00% <100.00%> (ø)
components/grid/col.tsx 100.00% <0.00%> (ø)
components/card/Grid.tsx 100.00% <0.00%> (ø)
components/_util/wave.tsx 100.00% <0.00%> (ø)
components/radio/group.tsx 100.00% <0.00%> (ø)
components/input/Search.tsx 100.00% <0.00%> (ø)
components/anchor/Anchor.tsx 100.00% <0.00%> (ø)
components/button/button.tsx 100.00% <0.00%> (ø)
components/tag/CheckableTag.tsx 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696396a...cc4df83. Read the comment docs.

@hengkx hengkx requested a review from zombieJ November 17, 2020 03:08
@zombieJ
Copy link
Member

zombieJ commented Nov 17, 2020

/rebase

@hengkx
Copy link
Member Author

hengkx commented Nov 17, 2020

这个错应该不影响吧

@zombieJ zombieJ merged commit 44e41b5 into master Nov 18, 2020
@zombieJ zombieJ deleted the r/t branch November 18, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants