Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make autosize true by default #27814

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

wf-francescoalbanese
Copy link
Contributor

Made autoSize = true by default deconstructing it from props, rather than explicitly checking if it's undefined at render times.

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Made `autoSize = true` by default deconstructing it from props, rather than explicitly checking if it's undefined at render times.
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 16, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed66208:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #27814 (ed66208) into master (2177548) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          390       390           
  Lines         7382      7382           
  Branches      2043      2043           
=========================================
  Hits          7382      7382           
Impacted Files Coverage Δ
components/typography/Editable.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2177548...ed66208. Read the comment docs.

@afc163 afc163 merged commit 696396a into ant-design:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants