Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FormItem support _internalItemRender #27881

Merged
merged 6 commits into from
Nov 20, 2020
Merged

feat: FormItem support _internalItemRender #27881

merged 6 commits into from
Nov 20, 2020

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Nov 19, 2020

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

为了支持可编辑表格

💡 需求背景和解决方案

让用户可以自定义 FormItem 的 dom 结构,这样可以将错误信息藏起来,或者修改为 hover 的方式

📝 更新日志

不希望用户使用

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 19, 2020

@chenshuai2144 chenshuai2144 changed the title feat: formitem support _internalItemRender feat: FormItem support _internalItemRender Nov 19, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2dd0d2f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #27881 (2dd0d2f) into master (4d383a6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27881   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7331      7336    +5     
  Branches      2087      2090    +3     
=========================================
+ Hits          7331      7336    +5     
Impacted Files Coverage Δ
components/button/LoadingIcon.tsx 100.00% <100.00%> (ø)
components/form/ErrorList.tsx 100.00% <100.00%> (ø)
components/form/FormItemInput.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d383a6...2dd0d2f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2020

Size Change: -49 B (0%)

Total Size: 788 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB -32 B (0%)
./dist/antd.min.js 276 kB -17 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.5 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@hengkx
Copy link
Member

hengkx commented Nov 20, 2020

不希望 用户 使用 这是 给 pro 专用的吗😂

@chenshuai2144
Copy link
Contributor Author

给我专用的

chenshuai2144 and others added 2 commits November 20, 2020 07:06
Co-authored-by: 二货机器人 <smith3816@gmail.com>
@zombieJ zombieJ merged commit 95ce54c into master Nov 20, 2020
@zombieJ zombieJ deleted the formItemProps branch November 20, 2020 13:43
@viewweiwu
Copy link

这个属性挺好的,刚好看到 Pro 里面有,找到这里来了。
开启了这个属性后,其它的二次封装也可以使用这个属性了。

@fanck0605
Copy link

这个接口能不能最设计成给普通用户使用呢,而不仅仅为了内部使用。

确实有需要实现 InlineErrorFormItem 类似功能的需求

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants