Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Layout overflow style for table sticky #28176

Merged
merged 3 commits into from Dec 5, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 3, 2020

close #28154

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #28154

💡 Background and solution

回滚 500b222 ,现在已经不清楚是为了啥加的,删后没看出明显的问题。

改成 width: 0 的解决方案避免内容溢出:https://segmentfault.com/a/1190000019498300

📝 Changelog

Language Changelog
🇺🇸 English Fix Layout overflow style for Table sticky.
🇨🇳 Chinese 修复 Layout 内部使用 Table sticky 属性失效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 3, 2020

@afc163 afc163 changed the title fix: Layout overflow style for table sticky [WIP] fix: Layout overflow style for table sticky Dec 3, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Dec 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Size Change: +193 B (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +3 B (0%)
./dist/antd.compact.min.css 66.7 kB +67 B (0%)
./dist/antd.dark.min.css 68 kB +58 B (0%)
./dist/antd.min.css 66.7 kB +62 B (0%)
./dist/antd.min.js 275 kB +3 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 858a24f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #28176 (858a24f) into master (273ab18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7384      7384           
  Branches      2113      2113           
=========================================
  Hits          7384      7384           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273ab18...858a24f. Read the comment docs.

@afc163 afc163 changed the title [WIP] fix: Layout overflow style for table sticky fix: Layout overflow style for table sticky Dec 4, 2020
@afc163 afc163 merged commit ebb6fcf into master Dec 5, 2020
@afc163 afc163 deleted the fix-layout-table-sticky branch December 5, 2020 15:07
@ycjcl868 ycjcl868 mentioned this pull request Dec 6, 2020
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
* fix: Layout overflow style for table sticky

close ant-design#28154

* fix: Layout content bigger width

https://segmentfault.com/a/1190000019498300

* Update index.less
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
* fix: Layout overflow style for table sticky

close ant-design#28154

* fix: Layout content bigger width

https://segmentfault.com/a/1190000019498300

* Update index.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在umi中,启用layout的情况下,antd的table sticky属性不生效
2 participants