New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: draggable Modal should have boundary #28476
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fa376f9:
|
Codecov Report
@@ Coverage Diff @@
## master #28476 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 7374 7376 +2
Branches 2121 2123 +2
=========================================
+ Hits 7374 7376 +2
Continue to review full report at Codecov.
|
Size Change: +23 B (0%) Total Size: 789 kB
ℹ️ View Unchanged
|
了解;限制 Modal 边框在浏览器窗口内以后还需要让draggle作用在body元素么 |
应该没必要了。 |
@afc163 辛苦看一下 我本地已经测试过~ |
不要混杂无关的改动。 |
https://preview-28476-ant-design.surge.sh/components/modal-cn/#components-modal-demo-modal-render 还是不行,最好不能在拖拽的时候拖出范围,而不是 drop 的时候再调整。 |
那就合并#28510, 这里rebase |
rebase下,抵消一些差异 |
我执行了 git rebase upstream/master 就同步了一些master的commits history 没有抵消差异 |
done |
PR commits 记录里没看到rebase |
因分支被我搞乱了 目前重新提pr :#28527 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#28438
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge
View rendered components/modal/demo/modal-render.md