Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumped version of rc-image 4.3.1 -> 4.4.0 #28486

Merged

Conversation

OmriGM
Copy link
Contributor

@OmriGM OmriGM commented Dec 22, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #28415

💡 Background and solution

I added zoom in/out using the mouse wheel in react-components/image (react-component/image#52), it was merged, and I bumped the version in Ant Design.

Please say if any documentation should be updated.

📝 Changelog

Language Changelog
🇺🇸 English Image is now zoomable with the mouse wheel while on preview mode.
🇨🇳 Chinese Image Preview 支持通过鼠标滚轮缩放图片。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Added zoom in/out using the mouse wheel
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 22, 2020

@github-actions
Copy link
Contributor

Size Change: +185 B (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +95 B (0%)
./dist/antd.min.js 275 kB +90 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.8 kB 0 B
./dist/antd.dark.min.css 68 kB 0 B
./dist/antd.min.css 66.8 kB 0 B

compressed-size-action

Copy link
Member

@shaodahong shaodahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc51774:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #28486 (cc51774) into feature (0f87360) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #28486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7397      7397           
  Branches      2129      2129           
=========================================
  Hits          7397      7397           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f87360...cc51774. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Dec 22, 2020

@shaodahong 需要补充 4.3.x 的一些 changelog 和关联相关的 issue:https://github.com/react-component/image/releases

@shaodahong
Copy link
Member

@shaodahong 需要补充 4.3.x 的一些 changelog 和关联相关的 issue:https://github.com/react-component/image/releases

https://github.com/react-component/image/releases/tag/v4.3.0
https://github.com/ant-design/ant-design/pull/28235/files

@afc163 afc163 changed the title Bumped version of rc-image 4.2.0 -> 4.4.0 feat: bumped version of rc-image 4.2.0 -> 4.4.0 Dec 24, 2020
@afc163 afc163 merged commit c32406b into ant-design:feature Dec 24, 2020
@yoyo837 yoyo837 changed the title feat: bumped version of rc-image 4.2.0 -> 4.4.0 feat: bumped version of rc-image 4.3.1 -> 4.4.0 Dec 24, 2020
@afc163 afc163 mentioned this pull request Jan 1, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants