ci: fix contains check #28666
Merged
ci: fix contains check #28666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5520cb8:
|
|
Size Change: 0 B Total Size: 797 kB ℹ️ View Unchanged
|
|
这样是不是够用了。 |
|
可以使用正则表达式么？例如 title.match |
够了，11 以后 再无 IE 😂 |
这个主要是写在 yml 配置里，怕不支持太复杂的语法。如果放到 js 里，就有很多办法了 |
kerm1it
approved these changes
Jan 4, 2021
afc163
reviewed
Jan 4, 2021
| @@ -60,7 +60,7 @@ jobs: | |||
| * Ant Design Pro Preview : https://prosite.z23.web.core.windows.net | |||
|
|
|||
| - name: check-ie | |||
| if: contains(github.event.issue.body, 'ant-design-issue-helper') == true && (contains(github.event.issue.title, 'IE') == true || contains(github.event.issue.title, 'Internet Explorer') == true) | |||
| if: contains(github.event.issue.body, 'ant-design-issue-helper') == true && github.event.issue.title.includes('IE9') == true || github.event.issue.title.includes('IE 9') == true || github.event.issue.title.includes('IE10') == true || github.event.issue.title.includes('IE 10') == true || github.event.issue.title.includes('IE11') == true || github.event.issue.title.includes('IE 11') == true || contains(github.event.issue.title, 'Internet Explorer') == true) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github 的自带函数不区分大小写校验
导致 #28659 校验 IE 通过
@kerm1it 有没有好的校验单个 IE 的办法，用 split(' ') ？但有人会用 IE11 之类的，所以还是决定直接校验大写 'IE'