Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix import statement #28819

Merged
merged 1 commit into from Jan 12, 2021
Merged

fix: Fix import statement #28819

merged 1 commit into from Jan 12, 2021

Conversation

hugorezende
Copy link
Contributor

@hugorezende hugorezende commented Jan 11, 2021 •
edited by yoyo837

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

This import type is breaking the application for Typescript < 3.8

馃挕 Background and solution

馃摑 Changelog

Just use import

Language Changelog
馃嚭馃嚫 English x
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

hugorezende referenced this pull request Jan 11, 2021
@afc163
perf(馃摝): upgrade rc-image to 5.x (#28727)
de1364a 
* refactor: upgrade rc-image to 5.x

reduce bundle size

* upgrade rc-image

* upgrade @ant-design/tools

ant-design/antd-tools#226

* rc-image 5.0.0

* fix image preview icon missing

* refactor code
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 11, 2021 •
edited

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21d3ae6:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 787 kB

鈩癸笍 View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 312 kB 0 B
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.1 kB 0 B
./dist/antd.min.css 66.9 kB 0 B
./dist/antd.min.js 273 kB 0 B

compressed-size-action

@yoyo837 yoyo837 changed the title Fix import statement f9xFix import statement Jan 12, 2021
@yoyo837 yoyo837 changed the title f9xFix import statement fix: Fix import statement Jan 12, 2021
@yoyo837 yoyo837 merged commit 93ef449 into ant-design:master Jan 12, 2021
@afc163 afc163 mentioned this pull request Jan 14, 2021
Closed
1 task
@afc163 afc163 mentioned this pull request Jan 21, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugorezende @ant-design-bot @yoyo837