Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slider): optimize tooltip align #29308

Merged
merged 1 commit into from Feb 10, 2021
Merged

chore(slider): optimize tooltip align #29308

merged 1 commit into from Feb 10, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Feb 10, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #28788

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize Slider align performance of tooltip.
🇨🇳 Chinese 优化 Slider 提示信息对齐性能。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 10, 2021

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e25115:

Sandbox Source
antd reproduction template Configuration
antd reproduction template (forked) Issue #28788

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2021

Size Change: +5 B (0%)

Total Size: 835 kB

Filename Size Change
./dist/antd-with-locales.min.js 337 kB +3 B (0%)
./dist/antd.min.js 296 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 67.1 kB 0 B
./dist/antd.dark.min.css 68.4 kB 0 B
./dist/antd.min.css 67.1 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #29308 (5e25115) into master (7368b05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7479      7478    -1     
  Branches      2143      2143           
=========================================
- Hits          7479      7478    -1     
Impacted Files Coverage Δ
components/slider/SliderTooltip.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7368b05...5e25115. Read the comment docs.

@zombieJ zombieJ merged commit a937675 into master Feb 10, 2021
@zombieJ zombieJ deleted the fix-slider-tooltip branch February 10, 2021 07:53
mumiao pushed a commit to mumiao/ant-design that referenced this pull request Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High CPU usage when using tooltipVisible on Slider
3 participants