Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(Badge): update cached isDotRef when isHidden" #30277

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Reverts #30090

close #30261

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge animation when switch to 0.
🇨🇳 Chinese 修复 Badge 切换到 0 时的动画错位问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title Revert: "fix(Badge): update cached isDotRef when isHidden" fix: Revert "fix(Badge): update cached isDotRef when isHidden" Apr 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2021

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #30277 (a86e043) into master (2140e81) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #30277      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         398       397       -1     
  Lines        7566      7522      -44     
  Branches     2127      2105      -22     
===========================================
- Hits         7564      7522      -42     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
components/badge/index.tsx 100.00% <ø> (ø)
components/space/Item.tsx 100.00% <0.00%> (ø)
components/page-header/index.tsx 100.00% <0.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts
components/space/index.tsx 100.00% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2140e81...a86e043. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: -35 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd-with-locales.min.js 339 kB -20 B (0%)
./dist/antd.min.js 298 kB -15 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.8 kB 0 B
./dist/antd.dark.min.css 65.1 kB 0 B
./dist/antd.min.css 63.8 kB 0 B

compressed-size-action

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 23, 2021

reopen #30088

@afc163 afc163 merged commit eec7eca into master Apr 23, 2021
@afc163 afc163 deleted the revert-30090-main-fix-badge-transition branch April 23, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge count 从1过渡到0的时候 UI bug
2 participants