Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the mistake that tooltip mount on wrong dom, when getPopupCo… #30963

Merged

Conversation

ymrdf
Copy link
Contributor

@ymrdf ymrdf commented Jun 11, 2021

…ntainer of tooltip's props is undefined or null

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. 当Tooltip的getPopupContainer属性为undefined或null时,getPopupContainer会覆盖掉传给RcTooltip的getTooltipContainer属性;这样,context中的getPopupContainer无效,造成Tooltip只能挂到body上。
  2. 修复办法是不再向RcTooltip传递props中的getPopupContainer

📝 Changelog

Language Changelog
🇺🇸 English fix the mistake that tooltip mount on wrong dom, when getPopupContainer of tooltip's props is undefined or null
🇨🇳 Chinese 修复Tooltip的getPopupContainer属性为undefined时,Tooltip只能挂载到body上的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

…ntainer of tooltip's props is undefined or null
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2021

@afc163 afc163 merged commit 832aa81 into ant-design:master Jun 11, 2021
@ycjcl868 ycjcl868 mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants