add table unique key warning & fix record key bug #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noonnightstorm, thanks for your PR! By analyzing the annotation information on this pull request, we identified @benjycui, @afc163 and @ddcat1115 to be potential reviewers |
benjycui
reviewed
Sep 27, 2016
| return record[rowKey as string] || index; | ||
| let recordKey = record[rowKey as string] !== undefined ? record[rowKey as string] : index; | ||
| warning(recordKey !== undefined, | ||
| 'Each record in table should have a unique "key" prop.' |
|
@benjycui done |
|
没理我呀。。 |
noonnightstorm
force-pushed
the
master
branch
from
0a32538
to
217335d
Compare
|
@afc163 done & rebase了以前的commit |
|
在dataSource 里每个对象都有添加key，还是报错，在本地写死数据没问题，从后台拉取就会报错 |
|
@zhanfenghai 如果认为是 bug 请按模板开新 issue，如果是使用问题建议上 stackoverflow 或者 segmentfault 上问。这样没头没脑的说一句，别人很难帮到你。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table组件的一个小建议 #3093