Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table preset SELECTION can modify disabled record #32027

Merged
merged 2 commits into from Sep 3, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 3, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #31994

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table.SELECT_XXX ignore record disabled status by getCheckboxProps.
🇨🇳 Chinese 修复 Table.SELECT_XXX 会无视 getCheckboxProps 提供的 disabled 状态问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #32027 (62168a0) into master (c29c46e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #32027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          399       399           
  Lines         7592      7601    +9     
  Branches      2135      2137    +2     
=========================================
+ Hits          7592      7601    +9     
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29c46e...62168a0. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Size Change: +134 B (0%)

Total Size: 833 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +57 B (0%)
./dist/antd.min.js 297 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 64.4 kB
./dist/antd.dark.min.css 65.7 kB
./dist/antd.min.css 64.6 kB

compressed-size-action

@zombieJ zombieJ merged commit 04d140d into master Sep 3, 2021
@zombieJ zombieJ deleted the fix-tbl-selection branch September 3, 2021 11:47
@xrkffgg xrkffgg mentioned this pull request Sep 6, 2021
19 tasks
lironhl pushed a commit to lironhl/ant-design that referenced this pull request Sep 6, 2021
)

* fix: tbl select opt affact disabled

* test: add disabled test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unavailable rows selected
1 participant