Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep index.js as entry #3397

Merged
merged 1 commit into from
Oct 31, 2016
Merged

keep index.js as entry #3397

merged 1 commit into from
Oct 31, 2016

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 12, 2016

原来是 dist/antd.js

如果没有使用 babel-plugin-import ,就没法享受底层依赖直接更新的好处。而且容易引发类似 #3400 的问题。

改回 index.js

@mention-bot
Copy link

@afc163, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @benjycui and @ibigbug to be potential reviewers.

@yiminghe
Copy link
Contributor

index.js 里面都是源码引用,这样改需要处理

@afc163 afc163 changed the title keep index.js as entry [WIP] keep index.js as entry Oct 13, 2016
@afc163
Copy link
Member Author

afc163 commented Oct 13, 2016

要能把这个文件自动构建出来才行:https://github.com/ant-design/ant-design/blob/0.12-stable/index.js

@afc163 afc163 force-pushed the use-index-as-main branch 2 times, most recently from 87bb05d to ebb14de Compare October 30, 2016 13:22
@afc163 afc163 changed the title [WIP] keep index.js as entry keep index.js as entry Oct 30, 2016
@afc163
Copy link
Member Author

afc163 commented Oct 30, 2016

直接用 lib/index.tsx 即可。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants