Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cssinjs alert #34285

Merged
merged 10 commits into from
Mar 4, 2022
Merged

refactor: cssinjs alert #34285

merged 10 commits into from
Mar 4, 2022

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 3, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese ---

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

@xrkffgg xrkffgg mentioned this pull request Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Size Change: +927 B (0%)

Total Size: 950 kB

Filename Size Change
./dist/antd-with-locales.min.js 377 kB +1.38 kB (0%)
./dist/antd.compact.min.css 61.8 kB -459 B (-1%)
./dist/antd.dark.min.css 63.2 kB -471 B (-1%)
./dist/antd.min.css 61.7 kB -453 B (-1%)
./dist/antd.min.js 324 kB +1.38 kB (0%)
./dist/antd.variable.min.css 62.5 kB -455 B (-1%)

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #34285 (1086218) into next (1cd87b4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              next    #34285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          426       426           
  Lines         7866      7872    +6     
  Branches      2271      2276    +5     
=========================================
+ Hits          7866      7872    +6     
Impacted Files Coverage Δ
components/_util/theme/default.tsx 100.00% <100.00%> (ø)
components/_util/theme/index.tsx 100.00% <100.00%> (ø)
components/_util/theme/util.tsx 100.00% <100.00%> (ø)
components/alert/index.tsx 100.00% <100.00%> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
components/checkbox/Group.tsx 100.00% <100.00%> (ø)
components/config-provider/context.tsx 100.00% <100.00%> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)
components/input/Input.tsx 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa90168...1086218. Read the comment docs.

@xrkffgg xrkffgg requested a review from zombieJ March 4, 2022 02:41
@zombieJ
Copy link
Member

zombieJ commented Mar 4, 2022

SSR 好像不全

截屏2022-03-04 上午10 47 45

marginInlineStart: marginXS,
},

'&-close-icon': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成 ${alertCls}-close-icon,其他地方直接使用 rootCls 都需要替换成 alertCls

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 4, 2022

input 的 test 先忽略吧

@xrkffgg xrkffgg requested a review from zombieJ March 4, 2022 07:29
@MadCcc
Copy link
Member

MadCcc commented Mar 4, 2022

master 上 input 有更新,rc-input 更新了个 alpha 版本,正在合到 next,合完了拉一下就行

@zombieJ zombieJ merged commit 8b1e5a2 into next Mar 4, 2022
@zombieJ zombieJ deleted the cs-alert branch March 4, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants