Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change divider into cssinjs #34364

Merged
merged 17 commits into from
Mar 10, 2022
Merged

Conversation

LongHaoo
Copy link
Contributor

@LongHaoo LongHaoo commented Mar 8, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Rewrite divider style with cssinjs.
🇨🇳 Chinese 重写 divider 样式,转而使用 cssinjs 实现。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #34364 (00d4e5c) into next (228d451) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              next    #34364   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          431       431           
  Lines         7942      7947    +5     
  Branches      2281      2281           
=========================================
+ Hits          7942      7947    +5     
Impacted Files Coverage Δ
components/_util/theme/index.tsx 100.00% <ø> (ø)
components/divider/index.tsx 100.00% <100.00%> (ø)
components/rate/index.tsx 100.00% <0.00%> (ø)
components/tree-select/index.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228d451...00d4e5c. Read the comment docs.

@zombieJ zombieJ mentioned this pull request Mar 9, 2022
components/divider/index.tsx Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Mar 10, 2022

@zombieJ zombieJ merged commit 4db1fc1 into ant-design:next Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants