Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactpor: Cascader with cssinjs #34374

Merged
merged 1 commit into from
Mar 8, 2022
Merged

refactpor: Cascader with cssinjs #34374

merged 1 commit into from
Mar 8, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 8, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👀 Preview

https://preview-34374-ant-design.surge.sh/components/cascader-cn/

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Refactor Cascader with cssinjs.
🇨🇳 Chinese 重构 Cascader 至 cssinjs 版本。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Size Change: -1.67 kB (0%)

Total Size: 947 kB

Filename Size Change
./dist/antd-with-locales.min.js 383 kB +603 B (0%)
./dist/antd.compact.min.css 58.1 kB -732 B (-1%)
./dist/antd.dark.min.css 59.5 kB -738 B (-1%)
./dist/antd.min.css 58.1 kB -759 B (-1%)
./dist/antd.min.js 330 kB +693 B (0%)
./dist/antd.variable.min.css 58.9 kB -737 B (-1%)

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #34374 (a17c530) into next (46e40df) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a17c530 differs from pull request most recent head 5762b52. Consider uploading reports for the commit 5762b52 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##              next    #34374   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          431       431           
  Lines         7936      7938    +2     
  Branches      2281      2281           
=========================================
+ Hits          7936      7938    +2     
Impacted Files Coverage Δ
components/_util/theme/index.tsx 100.00% <ø> (ø)
components/cascader/index.tsx 100.00% <100.00%> (ø)
components/input/Group.tsx 100.00% <100.00%> (ø)
components/typography/Typography.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c2b1a...5762b52. Read the comment docs.

@zombieJ zombieJ merged commit de24558 into next Mar 8, 2022
@zombieJ zombieJ deleted the cssinjs-cascader branch March 8, 2022 16:29
@zombieJ zombieJ mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant