Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cssinjs for Pagination #34661

Merged
merged 8 commits into from
Mar 30, 2022
Merged

refactor: cssinjs for Pagination #34661

merged 8 commits into from
Mar 30, 2022

Conversation

PeachScript
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#34087

💡 Background and solution

Migrate to cssinjs for Pagination component.

📝 Changelog

Language Changelog
🇺🇸 English Rewrite Pagination style with cssinjs.
🇨🇳 Chinese 使用 cssinjs 重写 Pagination 样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@PeachScript PeachScript mentioned this pull request Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #34661 (91c33cb) into next (d437f9f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next    #34661   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          438       438           
  Lines         8102      8103    +1     
  Branches      2302      2302           
=========================================
+ Hits          8102      8103    +1     
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d437f9f...91c33cb. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Size Change: -1.68 kB (0%)

Total Size: 930 kB

Filename Size Change
./dist/antd-with-locales.min.js 408 kB +1.88 kB (0%)
./dist/antd.compact.min.css 41.3 kB -1.35 kB (-3%)
./dist/antd.dark.min.css 42 kB -1.38 kB (-3%)
./dist/antd.min.css 41.3 kB -1.37 kB (-3%)
./dist/antd.min.js 355 kB +1.89 kB (+1%)
./dist/antd.variable.min.css 41.8 kB -1.35 kB (-3%)

compressed-size-action

@zombieJ zombieJ merged commit 25078f4 into next Mar 30, 2022
@zombieJ zombieJ deleted the feat/pagination-cssinjs branch March 30, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants