refactor: form cssinjs #34679
Merged
refactor: form cssinjs #34679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some components are broken in Form.Item because |
|
|
|
Size Change: -2.9 kB (0%) Total Size: 929 kB
|
Codecov Report
@@ Coverage Diff @@
## next #34679 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 438 438
Lines 8107 8115 +8
Branches 2302 2301 -1
=========================================
+ Hits 8107 8115 +8
Continue to review full report at Codecov.
|
zombieJ
reviewed
Mar 25, 2022
| @@ -5188,7 +5188,7 @@ exports[`renders ./components/form/demo/register.md extend context correctly 1`] | |||
| class="ant-form-item-control-input-content" | |||
| > | |||
| <div | |||
| class="ant-input-textarea ant-input-textarea-show-count" | |||
| class="ant-input-textarea ant-input-textarea-show-count ant-input-textarea-in-form-item" | |||
There was a problem hiding this comment.
这个应该是在 feature 上的？怎么 snapshot 也变了？
There was a problem hiding this comment.
这个样式没写在 components.less 里，漏掉了，我去 feature 上补一下
zombieJ
reviewed
Mar 25, 2022
components/input-number/index.tsx
Outdated
| @@ -55,7 +55,7 @@ const InputNumber = React.forwardRef<HTMLInputElement, InputNumberProps>((props, | |||
| const prefixCls = getPrefixCls('input-number', customizePrefixCls); | |||
|
|
|||
| // Style | |||
| const [wrapSSR, hashId] = useStyle(prefixCls, iconPrefixCls); | |||
| const [wrapSSR, hashId] = useStyle(prefixCls, iconPrefixCls || ''); | |||
There was a problem hiding this comment.
感觉有问题，这个 iconPrefixCls 应该总是存在才对
There was a problem hiding this comment.
这个 iconPrefixCls 不知道什么时候类型变成 string | undefined 了
zombieJ
reviewed
Mar 28, 2022
components/form/style/index.tsx
Outdated
| // Adjust output element | ||
| output: { | ||
| display: 'block', | ||
| paddingTop: '15px', |
zombieJ
reviewed
Mar 28, 2022
components/form/style/index.tsx
Outdated
| input[type='checkbox']:focus`]: { | ||
| // outline: 'thin dotted', | ||
| outline: '5px auto -webkit-focus-ring-color', | ||
| outlineOffset: -2, |
zombieJ
reviewed
Mar 28, 2022
components/form/style/index.tsx
Outdated
| marginBottom: 0, | ||
|
|
||
| '&-with-help': { | ||
| marginBottom: 24, // FIXME: magic |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge