Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/cssinjs in radio #34740

Merged
merged 19 commits into from
Apr 14, 2022
Merged

Refactor/cssinjs in radio #34740

merged 19 commits into from
Apr 14, 2022

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Mar 27, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Rewrite Radio style with cssinjs.
🇨🇳 Chinese 重写 Radio 样式，转而使用 cssinjs 实现。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited

Size Change: -541 B (0%)

Total Size: 907 kB

Filename Size Change
./dist/antd-with-locales.min.js 428 kB +1.61 kB (0%)
./dist/antd.compact.min.css 25.6 kB -937 B (-4%)
./dist/antd.dark.min.css 26.2 kB -926 B (-3%)
./dist/antd.min.css 25.5 kB -936 B (-4%)
./dist/antd.min.js 375 kB +1.58 kB (0%)
./dist/antd.variable.min.css 25.9 kB -936 B (-3%)

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 27, 2022 •
edited

Codecov Report

Merging #34740 (09ed5d4) into next (9f0397c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next    #34740   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          441       441           
  Lines         8197      8200    +3     
  Branches      2316      2316           
=========================================
+ Hits          8197      8200    +3
Impacted Files Coverage Δ
components/pagination/Select.tsx 100.00% <ø> (ø)
components/radio/group.tsx 100.00% <100.00%> (ø)
components/radio/radio.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0397c...09ed5d4. Read the comment docs.

@vagusX
Copy link
Member Author

vagusX commented Mar 29, 2022

image

@afc163 @zombieJ 这个 after 是干啥作用的呀

@vagusX vagusX mentioned this pull request Mar 30, 2022
Closed
@vagusX
Copy link
Member Author

vagusX commented Mar 30, 2022 •
edited

TODOs:

  • 样式问题
    image

  • 处理 radio button 的 prefixCls 问题，交由 radio 自行处理

image

  • size large 时折行的button 没有 border-left
    image

@vagusX vagusX requested a review from zombieJ March 30, 2022 14:01
@vagusX vagusX marked this pull request as ready for review March 30, 2022 14:01
@vagusX vagusX changed the title WIP: Refactor/cssinjs in radio Refactor/cssinjs in radio Mar 30, 2022
vagusX
vagusX commented Mar 30, 2022
View reviewed changes
components/radio/radio.tsx Outdated Show resolved Hide resolved
@vagusX vagusX changed the title Refactor/cssinjs in radio WIP: Refactor/cssinjs in radio Mar 31, 2022
@vagusX vagusX mentioned this pull request Apr 2, 2022
Merged
19 tasks
@vagusX
Copy link
Member Author

vagusX commented Apr 8, 2022 •
edited

等 next 合并了 feature 再更新 cc @zombieJ

@vagusX vagusX changed the title WIP: Refactor/cssinjs in radio Refactor/cssinjs in radio Apr 11, 2022
zombieJ
zombieJ reviewed Apr 11, 2022
View reviewed changes
components/pagination/Select.tsx
@@ -13,4 +13,3 @@ MiniSelect.Option = Select.Option;
MiddleSelect.Option = Select.Option;

export { MiniSelect, MiddleSelect };

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要变更，revert 一下~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 editorconfig 的默认行为吧？只是可能我打开过这个文件，然后就有了这个，我先撤销了，肯定是有人没安装 editorconfig 插件 @afc163
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里底部有两个空行，vscode 的 editorconfig 插件会自动补空行，但貌似不会自动删除多余的空行。

Copy link
Member Author

@vagusX vagusX Apr 13, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在看起来是被 lint 自动覆写改了，去也去不掉，所以要不留着吧 @zombieJ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有两个空行，这里可见 https://github.com/ant-design/ant-design/edit/next/components/pagination/Select.tsx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那就接受这个变更吧哈哈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先保留了

@vagusX
Copy link
Member Author

vagusX commented Apr 14, 2022

image

image

Badge 组件看起来丢了一段 rtl 样式

@vagusX vagusX requested a review from zombieJ April 14, 2022 08:06
@zombieJ
Copy link
Member

zombieJ commented Apr 14, 2022

截屏2022-04-14 下午4 42 47

@zombieJ zombieJ merged commit 10427f7 into next Apr 14, 2022
@zombieJ zombieJ deleted the refactor/cssinjs-in-radio branch April 14, 2022 11:14
@chenshuai2144 chenshuai2144 mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vagusX @zombieJ @afc163