Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor:Component Steps Less to cssInJs #35058

Merged
merged 14 commits into from
Apr 19, 2022

Conversation

zpc7
Copy link
Contributor

@zpc7 zpc7 commented Apr 15, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Steps support cssinjs
🇨🇳 Chinese Steps 支持 cssinjs

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

@zpc7 zpc7 force-pushed the refactor/cssinjs-Step branch 2 times, most recently from 365f3ea to 7fc03c0 Compare April 15, 2022 16:54
@zpc7 zpc7 changed the title [WIP]refactor:Component Steps Less to cssInJs Refactor:Component Steps Less to cssInJs Apr 16, 2022
@zpc7 zpc7 marked this pull request as ready for review April 16, 2022 01:56
@@ -16,7 +16,9 @@ const Diff: FC<DiffProps> = ({ show }) => {
title="master-diff"
style={{
position: 'absolute',
width: '100vw',
width: document.body.scrollWidth,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadCcc 确认一下这个改动

@zombieJ
Copy link
Member

zombieJ commented Apr 18, 2022

Rebase 一下~~

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #35058 (e6cd167) into next (9357e7f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next    #35058   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          441       450    +9     
  Lines         8196      8237   +41     
  Branches      2316      2316           
=========================================
+ Hits          8196      8237   +41     
Impacted Files Coverage Δ
components/form/Form.tsx 100.00% <ø> (ø)
components/form/context.tsx 100.00% <ø> (ø)
components/notification/index.tsx 100.00% <ø> (ø)
components/pagination/Select.tsx 100.00% <ø> (ø)
components/upload/Upload.tsx 100.00% <ø> (ø)
components/card/index.tsx 100.00% <100.00%> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <100.00%> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <100.00%> (ø)
components/form/hooks/useFormInstance.ts 100.00% <100.00%> (ø)
components/form/index.tsx 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fb0e8...e6cd167. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Apr 18, 2022

RTL 多了 padding:
截屏2022-04-18 下午3 27 30

原版:
截屏2022-04-18 下午3 27 55

@zombieJ zombieJ merged commit f4411d9 into ant-design:next Apr 19, 2022
@zombieJ zombieJ mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants