Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cssinjs for Breadcrumb #35125

Merged
merged 4 commits into from
May 23, 2022
Merged

refactor: cssinjs for Breadcrumb #35125

merged 4 commits into from
May 23, 2022

Conversation

PeachScript
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#34087

💡 Background and solution

Migrate to cssinjs for Breadcrumb component.

📝 Changelog

Language Changelog
🇺🇸 English Rewrite Breadcrumb style with cssinjs.
🇨🇳 Chinese 使用 cssinjs 重写 Breadcrumb 样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

@PeachScript PeachScript mentioned this pull request Apr 20, 2022
@PeachScript
Copy link
Member Author

依赖 Dropdown 的样式迁移,所以下拉菜单的样式有 diff

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

Size Change: +1.65 kB (0%)

Total Size: 893 kB

Filename Size Change
./dist/antd-with-locales.min.js 458 kB +1.65 kB (0%)
./dist/antd.compact.min.css 7.64 kB -147 B (-2%)
./dist/antd.dark.min.css 7.69 kB -146 B (-2%)
./dist/antd.min.css 7.67 kB -144 B (-2%)
./dist/antd.min.js 404 kB +587 B (0%)
./dist/antd.variable.min.css 8.05 kB -146 B (-2%)

compressed-size-action

@zombieJ
Copy link
Member

zombieJ commented Apr 20, 2022

依赖 Dropdown 的样式迁移,所以下拉菜单的样式有 diff

Hmm...那先 hold 一下,等 Dropdown 好了再合~

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #35125 (5ce93a2) into next (47d73d8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              next    #35125    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          469       472     +3     
  Lines         8490      8662   +172     
  Branches      2404      2471    +67     
==========================================
+ Hits          8490      8662   +172     
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 100.00% <100.00%> (ø)
components/popover/index.tsx 100.00% <0.00%> (ø)
components/tooltip/index.tsx 100.00% <0.00%> (ø)
components/popconfirm/index.tsx 100.00% <0.00%> (ø)
components/table/hooks/useSelection.tsx 100.00% <0.00%> (ø)
components/date-picker/locale/tk_TK.tsx 100.00% <0.00%> (ø)
components/time-picker/locale/tk_TK.tsx 100.00% <0.00%> (ø)
components/locale/tk_TK.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d73d8...5ce93a2. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Apr 25, 2022

Dropdown 合了~

@MadCcc MadCcc merged commit 3c506b8 into next May 23, 2022
@MadCcc MadCcc deleted the feat/cssinjs-breadcrumb branch May 23, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants