Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Anchor cssinjs #35139

Merged
merged 3 commits into from
Apr 29, 2022
Merged

refactor: Anchor cssinjs #35139

merged 3 commits into from
Apr 29, 2022

Conversation

LongHaoo
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English change anchor to cssinjs
🇨🇳 Chinese anchor 转换cssinjs

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

@LongHaoo
Copy link
Contributor Author

样式对比过没有问题,除了在Fixed状态后可能存在一些宽度高度变化问题需要最后check一下

@LongHaoo
Copy link
Contributor Author

affix的时候宽度是152px,而正确的时候应该是148px,每天在对一下Affix这个宽度怎么取的

@LongHaoo LongHaoo changed the title refactor: anchor cssinjs refactor: Anchor cssinjs Apr 20, 2022
@zombieJ
Copy link
Member

zombieJ commented Apr 20, 2022

CI 挂了,rebase 一下?

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #35139 (473fdf3) into next (b22aa64) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 473fdf3 differs from pull request most recent head 95f691d. Consider uploading reports for the commit 95f691d to get more accurate results

@@           Coverage Diff           @@
##             next   #35139   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         459      459           
  Lines        8304     8305    +1     
  Branches     2384     2384           
=======================================
+ Hits         8303     8304    +1     
  Misses          1        1           
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22aa64...95f691d. Read the comment docs.

@zombieJ zombieJ mentioned this pull request Apr 27, 2022
@zombieJ
Copy link
Member

zombieJ commented Apr 27, 2022

https://preview-35139-ant-design.surge.sh/components/anchor-cn/ 少侠,这个样式完全不对呐。。。

截屏2022-04-27 上午11 24 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants