Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Respect user provided space item key #35344

Merged
merged 1 commit into from May 5, 2022
Merged

fix: Respect user provided space item key #35344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions components/space/index.tsx
View file
Open in desktop
Expand Up @@ -88,15 +88,12 @@ const Space: React.FC<SpaceProps> = props => {
latestIndex = i;
}

const keyOfChild = child && child.key;
// Add `-space-item` as suffix in case simple key string trigger duplicated key warning
// https://github.com/ant-design/ant-design/issues/35305
const defaultKey = `${i}-space-item`;
const key = child && child.key || `${itemClassName}-${i}`;

return (
<Item
className={itemClassName}
key={`${itemClassName}-${keyOfChild || defaultKey}`}
key={key}
direction={direction}
index={i}
marginDirection={marginDirection}
Expand Down