Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Tooltip test case with testing library #35396

Merged

Conversation

zpc7
Copy link
Contributor

@zpc7 zpc7 commented May 5, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

@zpc7 zpc7 force-pushed the test/transfer-tooltip-to-testing-library branch 4 times, most recently from 0cec468 to d17bafd Compare May 6, 2022 15:26
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #35396 (bd31a6a) into master (1a788cf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #35396   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          424       424           
  Lines         7963      7963           
  Branches      2373      2372    -1     
=========================================
  Hits          7963      7963           
Impacted Files Coverage Δ
components/grid/row.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a788cf...bd31a6a. Read the comment docs.

@zpc7 zpc7 force-pushed the test/transfer-tooltip-to-testing-library branch from 0726031 to 55f9e29 Compare May 7, 2022 01:35
@zpc7 zpc7 marked this pull request as ready for review May 7, 2022 01:48
@zombieJ
Copy link
Member

zombieJ commented May 7, 2022

Coverage 降了

@zombieJ zombieJ merged commit 00fb822 into ant-design:master May 7, 2022
@hengkx
Copy link
Member

hengkx commented May 7, 2022

这个没有 squash?

@zombieJ zombieJ mentioned this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants