Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor useNotification #35423

Merged
merged 52 commits into from May 11, 2022
Merged

feat: refactor useNotification #35423

merged 52 commits into from May 11, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 7, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Refactor notification & message on more react way. And static function now only has one instance.
🇨🇳 Chinese 重构 notification 与 message 至 React 生命周期一致。静态方法现在只会存在一个实例。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

@zombieJ zombieJ marked this pull request as draft May 7, 2022 08:01
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

Size Change: +4.14 kB (0%)

Total Size: 901 kB

Filename Size Change
./dist/antd-with-locales.min.js 457 kB +3.26 kB (+1%)
./dist/antd.compact.min.css 10.2 kB -493 B (-5%)
./dist/antd.dark.min.css 10.7 kB -480 B (-4%)
./dist/antd.min.css 10.3 kB -485 B (-5%)
./dist/antd.min.js 403 kB +2.83 kB (+1%)
./dist/antd.variable.min.css 10.7 kB -496 B (-4%)

compressed-size-action

@zombieJ zombieJ changed the base branch from feature to next May 7, 2022 09:03
@zombieJ zombieJ marked this pull request as ready for review May 11, 2022 05:59
@zombieJ zombieJ changed the title [WIP] feat: refactor useNotification feat: refactor useNotification May 11, 2022
@ant-design ant-design deleted a comment from github-actions bot May 11, 2022
@zombieJ zombieJ merged commit 2341a25 into next May 11, 2022
@zombieJ zombieJ deleted the notification branch May 11, 2022 06:26
@MadCcc MadCcc mentioned this pull request Nov 17, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant