test: moving to testing-library in Tree
#35674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dancerphil
commented
May 23, 2022
| import debounce from 'lodash/debounce'; | ||
| import Tree from '../index'; | ||
| import React from 'react'; |
There was a problem hiding this comment.
import 顺序看起来是自动的🤔
Codecov Report
@@ Coverage Diff @@
## next #35674 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 469 469
Lines 8490 8490
Branches 2404 2404
=========================================
Hits 8490 8490 Continue to review full report at Codecov.
|
|
CI failed in React 18 |
|
rebased |
dancerphil
changed the title
TreeTree
|
react 18 会把 css-motion 运行结束后再匹配 snapshot，所以 dom 结构中不含有 motion 的部分。 不确定为什么 17 和 18 会有这个区别，猜测和 我是否可以通过在测试中加入额外的 jest.runAllTimers() 跳过动画，使得 react 17 和 react 18 的测试保持一致。同时，这个应该更符合 test 的初衷（测最终结果而不是动画的中间状态） |
dancerphil
changed the title
TreeTree
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge