refactor: timeline full token #35686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +418 B (0%) Total Size: 893 kB
|
Codecov Report
@@ Coverage Diff @@
## next #35686 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 469 472 +3
Lines 8490 8738 +248
Branches 2404 2507 +103
==========================================
+ Hits 8490 8738 +248
Continue to review full report at Codecov.
|
zombieJ
reviewed
May 23, 2022
components/timeline/style/index.tsx
Outdated
| timeLineItemPaddingBottom: number; | ||
| timeLineItemHeadSize: number; | ||
| timeLineItemCustomHeadPadding: string; | ||
| timeLineRightPadding: number; |
Closed
zombieJ
reviewed
May 24, 2022
components/timeline/style/index.tsx
Outdated
| const timeLineToken = mergeToken<TimelineToken>(token, { | ||
| timeLineItemPaddingBottom: token.padding * 1.25, | ||
| timeLineItemHeadSize: 10, | ||
| timeLineItemCustomHeadPadding: '3px 1px', |
There was a problem hiding this comment.
这个数字有点问题，我看了一下现在的 timeline 这个是 18，但是右侧的是 22。应该和 22 对齐，用 fontSize * lineHeight 反推一个出来~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge