test: testing-lib #37381

heiyu4585 · 2022-09-03T12:11:05Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	demoTest function
🇨🇳 Chinese	修改demoTest function 为 testing-lib

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

github-actions · 2022-09-03T12:11:16Z

afc163 · 2022-09-04T09:41:54Z

冲突了

MadCcc · 2022-09-05T06:46:59Z

这个是为啥要改

heiyu4585 · 2022-09-05T08:51:05Z

冲突了

收到

heiyu4585 · 2022-09-05T08:51:30Z

这个是为啥要改

demoTest function

MadCcc · 2022-09-06T02:50:17Z

snapshot 应该不变吧

heiyu4585 · 2022-09-06T09:11:42Z

snapshot 应该不变吧

恩,我不确定, 主要是这个文件的改动引起的,帮看下 /tests/shared/demoTest.tsx

afc163 · 2022-09-06T14:46:16Z

components/tree-select/__tests__/__snapshots__/demo.test.ts.snap

-    </span>
-  </label>
-  <label
-    class="ant-radio-button-wrapper"


snapshot 能保持不变么，这样 diff 有点大。

最终的的结果应该不大,主要是一些格式的东西,

(我会再把aria相关的属性 ignore掉,可能会再好一点)

我再找找看有没有格式配置

afc163 · 2022-09-07T06:53:55Z

tests/shared/demoTest.tsx

+          // @ts-ignore
+          child = child
+            .toString()
+            .replace(/ (aria-.*)=".+?"/g, ' $1=""')


这是干掉 aria- 么？

恩,忽略掉

afc163 · 2022-09-07T06:54:02Z

tests/shared/demoTest.tsx

+          child = child
+            .toString()
+            .replace(/ (aria-.*)=".+?"/g, ' $1=""')
+            .replace(/ id=".+?"/g, ' $1=""');


这是做啥？

https://www.jestjs.cn/docs/snapshot-testing#property-matchers

这个pr还继续么(要不我关了,去做新组件),巨佬 @afc163 我感觉我是不是走偏了

继续啊

ok

这个 tip 里是针对 id 不稳定的情况，id 稳定的情况还是希望能打出来了。现在去掉有点一刀切了。

这个 tip 里是针对 id 不稳定的情况，id 稳定的情况还是希望能打出来了。现在去掉有点一刀切了。

dist 里已经把 ENV 固化了,所以它拿到的一定不会是 test env,而是按照 dist 固化出来的 dev or production,dist 里有些 test 就直接 ignore 了

…nto dome-test

zombieJ · 2022-09-08T15:46:48Z

node env 报错是对的，因为 node 测试环境不应该有 jsdom。它需要对比的是序列化后的 html。这个需要走个分支处理一下。

codecov · 2022-09-09T07:18:16Z

Codecov Report

Merging #37381 (74aa516) into master (370c37c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #37381   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          443       443           
  Lines         8176      8177    +1     
  Branches      2403      2403           
=========================================
+ Hits          8176      8177    +1

Impacted Files	Coverage Δ
components/_util/reactNode.ts	`100.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

heiyu4585 force-pushed the dome-test branch from c576036 to 5010ae2 Compare September 5, 2022 02:09

heiyu4585 mentioned this pull request Sep 5, 2022

迁移 enzyme 至 test-lib #37229

Closed

15 tasks

heiyu4585 force-pushed the dome-test branch 2 times, most recently from 40e56a2 to 8203e79 Compare September 5, 2022 12:11

heiyu4585 added 2 commits September 5, 2022 20:33

test: replace testing-lib

7a1cbae

test: replace testing-lib

b6d7e33

heiyu4585 force-pushed the dome-test branch from 8489e02 to b6d7e33 Compare September 5, 2022 12:35

heiyu4585 added 5 commits September 5, 2022 20:55

test: replace testing-lib

94bf831

test: update snap

37331b8

test: replace testing-lib

252a676

test: replace testing-lib

c10f6a4

test: update for lint

0122467

heiyu4585 added 2 commits September 6, 2022 17:07

Merge branch 'master' into dome-test

f77a940

merge: merge

1bc21e8

heiyu4585 added 2 commits September 6, 2022 17:32

test: testing-lib

00b4b6c

test: replace testing-lib

4fbc1c6

afc163 reviewed Sep 6, 2022

View reviewed changes

test: testing-lib

05f08d9

afc163 reviewed Sep 7, 2022

View reviewed changes

heiyu4585 closed this Sep 7, 2022

heiyu4585 reopened this Sep 7, 2022

heiyu4585 requested a review from zombieJ September 7, 2022 08:43

zombieJ and others added 18 commits September 8, 2022 17:43

test: snapshot update

815b00f

test: fix snapshot rep logic

fe6380d

test: fix snapshot rep logic

86d2a81

test: fix snapshot rep logic

12a2d2e

chore: update demo

cc06f14

Merge branch 'dome-test' of https://github.com/heiyu4585/ant-design i…

db8325d

…nto dome-test

test: fix snapshot rep logic

ef4771d

Merge branch 'dome-test' of https://github.com/heiyu4585/ant-design i…

8d0b211

…nto dome-test

test: Update snapshot

2cb89ac

Merge branch 'dome-test' of https://github.com/heiyu4585/ant-design i…

540ebcd

…nto dome-test

test: rest snapshot

766db36

Merge remote-tracking branch 'origin/master' into dome-test

c3a796f

test: update snapshot

3b8a652

Merge branch 'dome-test' of https://github.com/heiyu4585/ant-design i…

079edd3

…nto dome-test

Merge branch 'master' into dome-test

bf2a6d0

test: Update test case

fff82d7

test: config env

0fbf9f5

chore: clean up

0ee7b14

heiyu4585 and others added 6 commits September 9, 2022 09:20

Merge branch 'master' into dome-test

88349ad

chore: Use renderServer instead

cbf659f

test: adjust testing logic

e060c73

test: modify test logic

bf0f25f

test: split ssr test

914eede

test: skip if need skip

285d65a

chore: ignore test file covv

74aa516

zombieJ merged commit 01ca7c7 into ant-design:master Sep 9, 2022

MadCcc mentioned this pull request Sep 14, 2022

chore: next merge master #37543

Merged

19 tasks

heiyu4585 mentioned this pull request Sep 23, 2022

v5 Task List #34087

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: testing-lib #37381

test: testing-lib #37381

heiyu4585 commented Sep 3, 2022 •

edited

github-actions bot commented Sep 3, 2022 •

edited

afc163 commented Sep 4, 2022

MadCcc commented Sep 5, 2022

heiyu4585 commented Sep 5, 2022

heiyu4585 commented Sep 5, 2022 •

edited

MadCcc commented Sep 6, 2022

heiyu4585 commented Sep 6, 2022 •

edited

afc163 Sep 6, 2022

heiyu4585 Sep 7, 2022

heiyu4585 Sep 7, 2022

afc163 Sep 7, 2022

heiyu4585 Sep 7, 2022

afc163 Sep 7, 2022

heiyu4585 Sep 7, 2022

heiyu4585 Sep 7, 2022

heiyu4585 Sep 7, 2022

heiyu4585 Sep 7, 2022 •

edited

afc163 Sep 7, 2022

heiyu4585 Sep 7, 2022

afc163 Sep 7, 2022

heiyu4585 Sep 7, 2022 •

edited

zombieJ commented Sep 8, 2022

codecov bot commented Sep 9, 2022 •

edited

test: testing-lib #37381

test: testing-lib #37381

Conversation

heiyu4585 commented Sep 3, 2022 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

github-actions bot commented Sep 3, 2022 • edited

afc163 commented Sep 4, 2022

MadCcc commented Sep 5, 2022

heiyu4585 commented Sep 5, 2022

heiyu4585 commented Sep 5, 2022 • edited

MadCcc commented Sep 6, 2022

heiyu4585 commented Sep 6, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heiyu4585 Sep 7, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heiyu4585 Sep 7, 2022 • edited

Choose a reason for hiding this comment

zombieJ commented Sep 8, 2022

codecov bot commented Sep 9, 2022 • edited

Codecov Report

heiyu4585 commented Sep 3, 2022 •

edited

github-actions bot commented Sep 3, 2022 •

edited

heiyu4585 commented Sep 5, 2022 •

edited

heiyu4585 commented Sep 6, 2022 •

edited

heiyu4585 Sep 7, 2022 •

edited

heiyu4585 Sep 7, 2022 •

edited

codecov bot commented Sep 9, 2022 •

edited