Optimize table selection #3757
Merged
Optimize table selection #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yesmeck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @ddcat1115 and @afc163 to be potential reviewers. |
yesmeck
force-pushed
the
optimize-table
branch
from
6dd29ee
to
aeb7eb7
Compare
|
这个 CI 很奇怪啊，一个是好的，一个是坏的。 |
|
Rebase. |
yesmeck
force-pushed
the
optimize-table
branch
from
aeb7eb7
to
4674fef
Compare
yesmeck
force-pushed
the
optimize-table
branch
from
4674fef
to
065cfdb
Compare
yesmeck
force-pushed
the
optimize-table
branch
from
065cfdb
to
fe403b3
Compare
jljsj33
pushed a commit
that referenced
this pull request
Nov 11, 2016
* Extract SelectionRadio, SelectionCheckbox, SelectionCheckboxAll * Add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 主要做了跟 react-component/table#95 类似的事情，把 selectedRowKeys 这个状态提出来，当有选择变化的时候只需要重新渲染对应的 cell。
另外 columns 还是需要 cache 的，具体想法见这里 #2884 (comment) 。