Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warning divider not support text #37697

Merged
merged 1 commit into from
Sep 22, 2022
Merged

chore: warning divider not support text #37697

merged 1 commit into from
Sep 22, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 22, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Divider shows children when in vertical mode.
🇨🇳 Chinese 修复 Divider 在 vertical 模式下仍然会错误展示 children 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

@github-actions
Copy link
Contributor

Size Change: +13 B (0%)

Total Size: 962 kB

Filename Size Change
./dist/antd-with-locales.min.js 374 kB +6 B (0%)
./dist/antd.min.js 316 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 67.5 kB
./dist/antd.dark.min.css 68.8 kB
./dist/antd.min.css 67.5 kB
./dist/antd.variable.min.css 68.1 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (30e26a0) compared to base (a6e620c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #37697   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          443       443           
  Lines         8200      8203    +3     
  Branches      2416      2418    +2     
=========================================
+ Hits          8200      8203    +3     
Impacted Files Coverage Δ
components/divider/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit af32d24 into master Sep 22, 2022
@zombieJ zombieJ deleted the warning-divider branch September 22, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant